add requires_utf8 argument to tests#7388
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7388 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 87 87
Lines 16754 16795 +41
=======================================
+ Hits 16591 16632 +41
Misses 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit 1d18cff Download link for the artifact containing the test results: ↓ atime-results.zip
|
|
Sorry if I'm late to note this, but wouldn't a more reliable test for this be the same thing as we currently use for ñ in test 2266? A test may require some symbols (ñ, ü, ん) to be representable in the native encoding. The symbols may be represented using Unicode escapes ( |
Good point. I have integrated this for the utf8_check. |
…' into tests_requires_utf8
MichaelChirico
left a comment
There was a problem hiding this comment.
2 more minor points, feel free to merge. Thanks!

Closes #7336
Closes #1343
Closes #7333